fix(extgen): preserve parse error when file.Close() succeeds in class parser#2351
Open
alexandre-daubois wants to merge 1 commit intophp:mainfrom
Open
fix(extgen): preserve parse error when file.Close() succeeds in class parser#2351alexandre-daubois wants to merge 1 commit intophp:mainfrom
alexandre-daubois wants to merge 1 commit intophp:mainfrom
Conversation
dunglas
requested changes
Apr 23, 2026
Comment on lines
214
to
217
| e := file.Close() | ||
| if err != nil { | ||
| if err == nil { | ||
| err = e | ||
| } |
Member
There was a problem hiding this comment.
return errors.Join(err, file.Close())
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes error propagation in the extgen class parser so that parsing errors are not accidentally overwritten by a successful file.Close(), and adds a regression test to ensure an orphan //export_php:method directive correctly fails parsing.
Changes:
- Fix
parseMethodsdeferredClose()handling to only return a close error when parsing succeeded. - Add a unit test covering an orphan
//export_php:methoddirective (not followed by afunc).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/extgen/classparser.go |
Corrects deferred file-close error handling so parse errors are preserved. |
internal/extgen/classparser_test.go |
Adds regression coverage for orphan method directive parsing failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.